Update topology toolbar tooltip to include movement blocking #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All topology tools needed this fix, as did the oval drawing tool. Each one of these failed to call `super.mouseMoved()` in their respective overrides but now do so at the start of the method. The board and grid adjust tools were similar, but did not need their overrides at all.
This ensures the mouse coordinates are saved and the coordinate status bar is updated, regardless of whatever else happens in these methods.
This is a legacy label implementation, referenced nowhere except during serialization. We have to keep it around because campaigns may have them serialized. However the corresponding tool `DrawnTextTool` is unused and has been removed, and some parts of `DrawnLabel` could be removed as well.
kwvanderlinde
force-pushed
the
bugfix/4772-topology-tool-coordinates
branch
from
bb9b0e8
to
0c1e2cd
Compare
cwisniew
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4772
Description of the Change
Some tools were missing calls to
DefaultTool.mouseMoved()in their overrides of that method, which meant the coordinates were not being updated. This includes all the topology tools, the oval drawing tool, the adjust board tool, and the adjust grid tool.The pointer tool, stamp tool, and line drawing tool were updated to be consistent about calling
DefaultTool.mouseMoved()at the start of their overrides. This doesn't change or fix anything, but makes sure it won't get missed regardless of the conditions set in these overrides.DrawnLabelappears to be a legacy label implementation. Its corresponding tool,DrawnTextToolalso has the coordinate problem. But since it is unused, I deleted it instead of fixing it.Also noticed the tooltip for the topology toolbar only mentioned VBL. So I changed it from
Vision Blocking Layer (VBL) ToolstoTopology Tools (Vision and Movement Blocking Layer)Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is